spirv: impl Debug + Display
, fix Affine::from_cols_array()
#559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to get a 👍 from the rust-gpu maintainers before this is merged, but feel free to already review this. Thanks :D
Added features for the spirv target:
#[cfg(not(target_arch = "spirv"))]
hiding the traits impls for the spirv target.Affine::from_cols_array()
not use any slices internally and use arrays instead, as this caused compilation errors when these methods were used on the spirv target.I tested this PR against embark's rust-gpu master branch and the latest v0.9.0 release using their compiletest suite.
(Note: test
member_ref_arg-broken
may fail on v0.9.0 due to a diff in stdout caused by newer spirv tools)